Skip to content

chore: fix to update one pod at a time in a rolling update #9810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 21, 2025
Merged

chore: fix to update one pod at a time in a rolling update #9810

merged 3 commits into from
Oct 21, 2025

Conversation

@leon-inf
Copy link
Contributor

cherry picked from commit c620878

@leon-inf leon-inf added this to the Release 1.0.2 milestone Oct 15, 2025
@leon-inf leon-inf requested a review from a team as a code owner October 15, 2025 08:00
@apecloud-bot
Copy link
Collaborator

Auto Cherry-pick Instructions

Usage:
  - /nopick: Not auto cherry-pick when PR merged.
  - /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.

Example:
  - /nopick
  - /pick release-1.0

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Oct 15, 2025
@leon-inf
Copy link
Contributor Author

/nopick

@apecloud-bot apecloud-bot added the nopick Not auto cherry-pick when PR merged label Oct 15, 2025
@leon-inf
Copy link
Contributor Author

/approve

@apecloud-bot apecloud-bot added the approved PR Approved Test label Oct 15, 2025
@codecov
Copy link

codecov bot commented Oct 15, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 43.85965% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.03%. Comparing base (497af27) to head (974180e).
⚠️ Report is 1 commits behind head on release-1.0.

Files with missing lines Patch % Lines
pkg/controller/instanceset/reconciler_update.go 40.74% 23 Missing and 9 partials ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           release-1.0    #9810      +/-   ##
===============================================
+ Coverage        59.89%   60.03%   +0.13%     
===============================================
  Files              493      493              
  Lines            54664    54677      +13     
===============================================
+ Hits             32743    32825      +82     
+ Misses           18917    18849      -68     
+ Partials          3004     3003       -1
Flag Coverage Δ
unittests 60.03% <43.85%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@apecloud-bot apecloud-bot removed the approved PR Approved Test label Oct 20, 2025
@apecloud-bot apecloud-bot added the approved PR Approved Test label Oct 20, 2025
@leon-inf leon-inf merged commit f897e51 into release-1.0 Oct 21, 2025
53 of 54 checks passed
@leon-inf leon-inf deleted the support/rolling-update-one-replica branch October 21, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjc7373 cjc7373 cjc7373 approved these changes

@apecloud-bot apecloud-bot apecloud-bot approved these changes

Assignees

No one assigned

Labels

approved PR Approved Test nopick Not auto cherry-pick when PR merged size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Milestone

Release 1.0.2

Development

Successfully merging this pull request may close these issues.

4 participants

@leon-inf @apecloud-bot @cjc7373